Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream carfield/astral features to main #87

Merged
merged 294 commits into from
Feb 24, 2025
Merged

Upstream carfield/astral features to main #87

merged 294 commits into from
Feb 24, 2025

Conversation

belanoa
Copy link
Collaborator

@belanoa belanoa commented Nov 13, 2024

No description provided.

Yvan Tortorella and others added 30 commits August 1, 2023 18:15
base address input for routing requests. Propagated cluster index only
to cores.
bender: Put TRACE_EXECUTION under target simulation
work (to be fixed and aligned with Carfield memory map).
@@ -44,7 +52,13 @@ sources:
- rtl/cluster_clock_gate.sv
- rtl/cluster_event_map.sv
- rtl/cluster_timer_wrap.sv
- rtl/dmac_wrap.sv
- rtl/obi_pulp_adapter.sv
- target: mchan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proliferation of targets with potentially misleading names is a bit dangerous. I think this is safe, but maybe pulp_cluster_mchan would be a better name.

ROOT_DIR = $(strip $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST)))))

HOSTNAME := $(shell hostname)
ETH_HOST = $(shell echo $(HOSTNAME) | grep -q "\.ee\.ethz\.ch$$" && echo 1 || echo 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "standard" way to do this is

ifneq (,$(wildcard /etc/iis.version))
	QUESTA ?= questa-2023.4-zr
else
	QUESTA ?=
endif

@FrancescoConti
Copy link
Member

@belanoa time to bring this one home! 😎

@belanoa belanoa merged commit 6f1a26c into master Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants